Repository navigation
Conversation
mulewicz
requested review from
alibuild,
fjonasALICE,
jaimenorman,
mhemmer-cern and
nzardosh
as code owners
November 4, 2026 15:34
|
O2 linter results: ❌ 0 errors, |
github-actions
Bot
changed the title
nzardosh
reviewed
Nov 4, 2026
| DECLARE_SOA_COLUMN(NKaons, nKaons, int32_t); | ||
| DECLARE_SOA_COLUMN(NProtons, nProtons, int32_t); | ||
| } // namespace qgmltruthjet | ||
| DECLARE_SOA_TABLE(QGMLTruthJets, "AOD", "QGMLTJET", |
Collaborator
There was a problem hiding this comment.
the fact that the description and name of the table are different will cause an issue with the merger later, unless you use the special DECLARE_SOA_INDEX_COLUMN_CUSTOM macro
Contributor
Author
There was a problem hiding this comment.
so I need to replace DECLARE_SOA_INDEX_COLUMN(QGMLTruthJet, qGMLTruthJet) with DECLARE_SOA_INDEX_COLUMN_CUSTOM(QGMLTruthJet, qGMLTruthJet, "QGMLTJET") around line 210, right? and for the other index declarations analogically
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends the quark-gluon jet ML producer with dedicated truth-level jet and constituent tables, as well as reconstructed-to-truth jet matching information.